Refactor Copr support into modules #344

ehelms · 2023-04-07T20:46:00Z

Start of re-factoring into modules based on our learning from Koji interaction. One aspect of this is how we define the data, while I am going to work on tests, I thinking of a data structure like this:

      copr_repo_name: 'foreman-nightly'
      chroots:
        - name: rhel-9-x86_64
          external_repo:
          modules:
        - name: rhel-8-x86_64
          external_repo:
          modules:
        - name: rhel-7-x86_64
          external_repo:
          modules:

ehelms · 2023-04-11T17:36:40Z

Will require #345 to go in first and be rebased on how the modules work there.

ehelms · 2023-05-05T19:05:05Z

I have updated this with a rebase onto master, and pushing up all the changes from testing builds locally.

ehelms · 2023-05-12T02:06:48Z

I don't understand why this only fails on 3.11. The failing line:

https://github.com/theforeman/obal/pull/344/files#diff-103a9c682c1c4b5acd91a508a254c48b6712a50b2968f7b7c2d26f08869450d8R37

Where I have the mock printing out JSON like the copr-cli would:

https://github.com/theforeman/obal/pull/344/files#diff-158adaf76a7a5801ea8eafe90f5149f58986ed540ee684aa2ab498294476070eR196-R197

evgeni · 2023-05-16T07:49:01Z

% ./tests/fixtures/mockbin/copr-cli 
/home/evgeni/Devel/theforeman/obal/./tests/fixtures/mockbin/copr-cli:10: DeprecationWarning: 'pipes' is deprecated and slated for removal in Python 3.13
  from pipes import quote
{}

that ain't no valid json? :-)

Fix: #349

ehelms · 2023-05-16T12:45:33Z

% ./tests/fixtures/mockbin/copr-cli 
/home/evgeni/Devel/theforeman/obal/./tests/fixtures/mockbin/copr-cli:10: DeprecationWarning: 'pipes' is deprecated and slated for removal in Python 3.13
  from pipes import quote
{}

that ain't no valid json? :-)

Fix: #349

Thanks! I need to squint harder next time.

ehelms · 2023-05-16T17:44:01Z

This is ready for review. It is helpful to review it with respect to theforeman/foreman-packaging#9290 as that gives it some real world feel.

ehelms · 2023-07-08T02:18:04Z

@evgeni What would you recommend we do here? Drop 2.7 support or test it via a different method?

  Warning: The support for python 2.7 will be removed on June 19. Related issue: https://github.com/actions/setup-python/issues/672
  Version 2.7 was not found in the local cache
  Error: The version '2.7' with architecture 'x64' was not found for Ubuntu 20.04.

obal/data/module_utils/copr.py

evgeni · 2023-07-12T10:16:32Z

obal/data/modules/check_copr_build.py

+    try:
+        package_info = json.loads(copr_cli(command, config_file=config_file))
+    except CoprCliCommandError as error:
+        if "Error: No package with name {} in copr {}".format(package, project):


this is if <a string>: which is always true, did you forget to match against some output?

Rather than matching here, can we catch this in copr_cli and implement a specific CoprPackageRetrievalError exception (which subclasses CoprCliCommandError?

obal/data/modules/check_copr_build.py

obal/data/modules/copr_chroot.py

obal/data/roles/build_package/tasks/copr_build.yml

tests/fixtures/mockbin/mockbin

evgeni · 2023-07-12T10:36:23Z

@evgeni What would you recommend we do here? Drop 2.7 support or test it via a different method?

  Warning: The support for python 2.7 will be removed on June 19. Related issue: https://github.com/actions/setup-python/issues/672
  Version 2.7 was not found in the local cache
  Error: The version '2.7' with architecture 'x64' was not found for Ubuntu 20.04.

I'd prefer fixing CI (I started in #352), but that shouldn't be a blocker for now.

evgeni

I've posted a few questions inline, but only the if <a string>: I'd consider blocking. Feel free to merge in my absence once that one is cleaned out.

obal/data/modules/check_copr_build.py

obal/data/modules/copr_build.py

ehelms · 2023-07-14T11:28:13Z

The Python 2.7 tests are currently known to be broken, attempting to be fixed over here -- #352

ehelms force-pushed the refactor-copr branch from 7761102 to b843a9a Compare April 11, 2023 16:00

ehelms force-pushed the refactor-copr branch 2 times, most recently from 9681962 to 8b9bf8d Compare April 20, 2023 20:28

ehelms force-pushed the refactor-copr branch 2 times, most recently from d49c59f to cc94cfe Compare May 5, 2023 19:03

ehelms marked this pull request as ready for review May 5, 2023 19:04

ehelms force-pushed the refactor-copr branch from cc94cfe to d92c01c Compare May 12, 2023 01:21

evgeni force-pushed the refactor-copr branch from d92c01c to 7b64028 Compare May 16, 2023 10:02

ehelms force-pushed the refactor-copr branch from 7b64028 to 851ad96 Compare May 16, 2023 12:45

ehelms mentioned this pull request May 16, 2023

Manage Copr projects theforeman/foreman-packaging#9290

Merged

ehelms force-pushed the refactor-copr branch from 851ad96 to 088bae1 Compare May 17, 2023 01:48

ehelms force-pushed the refactor-copr branch from 088bae1 to 59036cf Compare June 1, 2023 02:03

ehelms mentioned this pull request Jun 1, 2023

Add RPM PR test job for Copr theforeman/jenkins-jobs#343

Merged

ehelms force-pushed the refactor-copr branch 9 times, most recently from 2f82d21 to 887c3eb Compare July 8, 2023 02:08

ehelms force-pushed the refactor-copr branch from 887c3eb to 04f3724 Compare July 10, 2023 17:40

ehelms force-pushed the refactor-copr branch 2 times, most recently from c80c28f to 1931a35 Compare July 10, 2023 23:19